This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Bug] ContentPage.ControlTemplate gets not rendered in Wpf (#7671) #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a better solution? Because in the Please, have a closer look to my changes. |
neolithos
commented
Sep 29, 2019
| { | ||
| public class FormsContentPage : FormsPage | ||
| { | ||
| public FormsContentPage() | ||
| { | ||
| this.DefaultStyleKey = typeof(FormsContentPage); |
There was a problem hiding this comment.
Why not using the FrameworkPropertyMetadata?
samhouts
added
in-progress
|
What is missing? What is wrong? |
|
@neolithos Could you rebase master to fix the conflict, please? |
|
deleted I found out, what I did wrong. It should be correct, now. |
|
I rebased this a more than ones since 2019. But how do I solve this: |
rmarinho
removed
the
retarget-branch-required
Style issues Layout was applied on the content and not the visual first child Fix: typo Shared project fix Xml-Tag Fix for issue xamarin#7671 Style issues Layout was applied on the content and not the visual first child Fix: typo
jfversluis
force-pushed
the
issue-7671
branch
from
a6b4020 to
5dc6752
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Epic! It took a little while (🤏 ) but finally got to look at this. It works for the Xamarin Community Toolkit sample app! Thanks for this great contribution! |
|
That was long... |
|
At least it wasn't never! 🎉 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
PageRendererrenderes the first child instead of theContent.Sorry, I destroyed the branch #7672.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
ControlTemplate gets rendered in wpf.
Before/After Screenshots
Before:
After:
PR Checklist