Skip to content

Commit

Permalink
[NearbyInterction] Add support for xcode 13 beta 4. (#12351)
Browse files Browse the repository at this point in the history
  • Loading branch information
mandel-macaque authored Aug 5, 2021
1 parent 0ffed97 commit 244232d
Show file tree
Hide file tree
Showing 8 changed files with 29 additions and 47 deletions.
4 changes: 2 additions & 2 deletions src/NearbyInteraction/Enums.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace NearbyInteraction {

[NoWatch, NoTV, NoMac, iOS (14,0)]
[Watch (8,0), NoTV, NoMac, iOS (14,0)]
[ErrorDomain ("NIErrorDomain")]
[Native]
public enum NIErrorCode : long
Expand All @@ -26,7 +26,7 @@ public enum NIErrorCode : long
UserDidNotAllow = -5884,
}

[NoWatch, NoTV, NoMac, iOS (14,0)]
[Watch (8,0), NoTV, NoMac, iOS (14,0)]
[Native]
public enum NINearbyObjectRemovalReason : long
{
Expand Down
4 changes: 2 additions & 2 deletions src/NearbyInteraction/NINearbyObject.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
using ObjCRuntime;
using Vector3 = global::OpenTK.Vector3;

#if __IOS__
#if __IOS__ || WATCH
namespace NearbyInteraction {
partial class NINearbyObject
{
Expand All @@ -38,4 +38,4 @@ public static Vector3 DirectionNotAvailable {
}

}
#endif //__IOS__
#endif
1 change: 1 addition & 0 deletions src/frameworks.sources
Original file line number Diff line number Diff line change
Expand Up @@ -2147,6 +2147,7 @@ WATCHOS_FRAMEWORKS = \
MapKit \
MediaPlayer \
MobileCoreServices \
NearbyInteraction \
PassKit \
PushKit \
Security \
Expand Down
29 changes: 23 additions & 6 deletions src/nearbyinteraction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@

namespace NearbyInteraction {

[NoWatch, NoTV, NoMac, iOS (14,0)]
[Watch (8,0), NoTV, NoMac, iOS (14,0)]
[MacCatalyst (14,0)]
[BaseType (typeof (NSObject))]
[DisableDefaultCtor]
interface NIConfiguration : NSCopying, NSSecureCoding {}

[NoWatch, NoTV, NoMac, iOS (14,0)]
[Watch (8,0), NoTV, NoMac, iOS (14,0)]
[MacCatalyst (14,0)]
[BaseType (typeof (NSObject))]
[DisableDefaultCtor]
interface NIDiscoveryToken : NSCopying, NSSecureCoding {}

[NoWatch, NoTV, NoMac, iOS (14,0)]
[Watch (8,0), NoTV, NoMac, iOS (14,0)]
[MacCatalyst (14,0)]
[BaseType (typeof (NIConfiguration))]
[DisableDefaultCtor]
Expand All @@ -40,7 +40,7 @@ interface NINearbyPeerConfiguration
IntPtr Constructor (NIDiscoveryToken peerToken);
}

[NoWatch, NoTV, NoMac, iOS (14,0)]
[Watch (8,0), NoTV, NoMac, iOS (14,0)]
[MacCatalyst (14,0)]
[BaseType (typeof (NSObject))]
[DisableDefaultCtor]
Expand All @@ -62,7 +62,7 @@ Vector3 Direction {
float DistanceNotAvailable { get; }
}

[NoWatch, NoTV, NoMac, iOS (14,0)]
[Watch (8,0), NoTV, NoMac, iOS (14,0)]
[MacCatalyst (14,0)]
[BaseType (typeof (NSObject))]
interface NISession
Expand Down Expand Up @@ -99,7 +99,7 @@ interface NISession

interface INISessionDelegate {}

[NoWatch, NoTV, NoMac, iOS (14,0)]
[Watch (8,0), NoTV, NoMac, iOS (14,0)]
[MacCatalyst (14,0)]
[Protocol]
[Model (AutoGeneratedName = true)]
Expand All @@ -120,5 +120,22 @@ interface NISessionDelegate

[Export ("session:didInvalidateWithError:")]
void DidSessionInvalidate (NISession session, NSError error);

[Watch (8,0), NoTV, NoMac, iOS (15,0), MacCatalyst (15,0)]
[Export ("session:didGenerateShareableConfigurationData:forObject:")]
void DidGenerateShareableConfigurationData (NISession session, NSData shareableConfigurationData, NINearbyObject @object);
}

[Watch (8,0), NoTV, NoMac, iOS (15,0), MacCatalyst (15,0)]
[BaseType (typeof (NIConfiguration))]
[DisableDefaultCtor]
interface NINearbyAccessoryConfiguration
{
[Export ("accessoryDiscoveryToken", ArgumentSemantic.Copy)]
NIDiscoveryToken AccessoryDiscoveryToken { get; }

[Export ("initWithData:error:")]
IntPtr Constructor (NSData data, [NullAllowed] out NSError error);
}

}
4 changes: 0 additions & 4 deletions tests/xtro-sharpie/MacCatalyst-NearbyInteraction.todo

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/iOS-NearbyInteraction.todo

This file was deleted.

29 changes: 0 additions & 29 deletions tests/xtro-sharpie/watchOS-NearbyInteraction.todo

This file was deleted.

1 change: 1 addition & 0 deletions tools/common/Frameworks.cs
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,7 @@ public static Frameworks GetwatchOSFrameworks (bool is_simulator_build)
{ "UniformTypeIdentifiers", "UniformTypeIdentifiers", 7,0 },

{ "Chip", "CHIP", new Version (8, 0), NotAvailableInSimulator /* no headers in beta 2 */ },
{ "NearbyInteraction", "NearbyInteraction", 8,0 },
};
}
return watch_frameworks;
Expand Down

5 comments on commit 244232d

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

Packages generated

View packages

Test results

2 tests failed, 223 tests passed.

Failed tests

  • Documentation/All: Failed
  • DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1027.BigSur'
[NearbyInterction] Add support for xcode 13 beta 4. (#12351)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[NearbyInterction] Add support for xcode 13 beta 4. (#12351)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
[NearbyInterction] Add support for xcode 13 beta 4. (#12351)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[NearbyInterction] Add support for xcode 13 beta 4. (#12351)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[NearbyInterction] Add support for xcode 13 beta 4. (#12351)

Please sign in to comment.