[AVKit] Add support for xcode 12 beta 5. #12551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel-macaque
added
the
note-highlight
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results23 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099.BigSur' |
spouliot
approved these changes
Aug 26, 2021
src/avkit.cs
Outdated
| @@ -497,6 +535,15 @@ interface AVPlayerView { | |||
| [Mac (10,15)] | |||
| [Export ("showsTimecodes")] | |||
| bool ShowsTimecodes { get; set; } | |||
|
|
|||
| [Mac (12,0), NoiOS, NoTV, NoMacCatalyst] | |||
There was a problem hiding this comment.
NoiOS, NoTV, NoMacCatalyst] are already present at the type-level
src/avkit.cs
Outdated
| [Protocolize] | ||
| AVPlayerViewDelegate Delegate { get; set; } | ||
|
|
||
| [Mac (12,0), NoiOS, NoTV, NoMacCatalyst] |
There was a problem hiding this comment.
NoiOS, NoTV, NoMacCatalyst] are already present at the type-level
dalexsoto
approved these changes
Aug 26, 2021
rolfbjarne
approved these changes
Aug 26, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 107 tests passed.Failed tests
Pipeline on Agent XAMBOT-1107.BigSur' |
|
Unrelated failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.