[xcode13.3] Update bindings to Xcode 13.3 #14415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring CHIP framework for now since it is not stable just yet and we want to avoid breaking changes in the future.
We can update it once xamarin#14303 lands
dalexsoto
added
the
note-highlight
rolfbjarne
approved these changes
Mar 15, 2022
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results1 tests failed, 104 tests passed.Failed tests
Pipeline on Agent XAMBOT-1042.Monterey' |
mandel-macaque
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the same set of commits to the old Xcode 13.3 PR + the feedback minus the GameController test, I could not find a good way to test GCDualSenseAdaptiveTriggerPositionalAmplitudes and GCDualSenseAdaptiveTriggerPositionalResistiveStrengths without a PS5 controller, that said we have other instances of structs with LayoutKind.Sequential that the generator takes care of the marshaling code so I think we should be fine to keep the API using these two simple structures and we do not have any manual code using them.
Feel free to debate if you think otherwise and we can disable them for the time being.
Xcode 13.3 RC is the same as Xcode 13.3 Final, the later has not been uploaded to prov.