-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net8.0] [dotnet] Add support for multi-targeting. #18931
[net8.0] [dotnet] Add support for multi-targeting. #18931
Conversation
🔥 Failed to compare API and create generator diff 🔥 Failed to update apidiff references Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 3 tests failed, 230 tests passed. Failures❌ xammac tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2630). |
[net8.0] [dotnet] Add support for multi-targeting.
Multi targetting is described here:
https://github.com/xamarin/xamarin-macios/blob/main/docs/multi-target-framework.md
This PR implements support for:
In both cases by specifying the OS version in the target framework.
Additionally adding support for any other API/OS version is trivial: it's just
a matter of listing the corresponding versions in a few files (this is
particularly interesting to add support for preview versions).
It does so by:
Renaming the ref, sdk and runtime packs to contain the target framework and
the target platfrom version, so the packages will now be named:
iOS
tvOS
Mac Catalyst
macOS
Updating the WorkloadManifest.json and WorkloadManifest.targets files to
load the correct packs according to the TargetFramework in the developer's
project.
We're also now giving a better error message for invalid/unsupported/eol'ed
target frameworks. Fixes Improve error message when targeting net6.0-ios and net6.0-macos from net 8 #18790.
Add a few tests.
Fixes:
net7.0-ios
+net6.0-ios
packages forces consumers to build with net7 workloads dotnet/sdk#30103.Contributes towards: