[RGen] Implement the BindFrom attribute. #22087

mandel-macaque · 2025-01-31T13:18:17Z

The BindFromAttribute is similar to the BindAsAttribute but in the opossite direction. This allows the bindings to be cleaner since we can specify in the partial method the return type we really want and the NSNumber/NSString transformation will be done in the generated code.

github-actions · 2025-01-31T13:22:39Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

StephaneDelcroix · 2025-01-31T19:16:51Z

src/rgen/Microsoft.Macios.Generator/Attributes/BindFromData.cs

+
+
+	public static bool TryParse (AttributeData attributeData,
+		[NotNullWhen (true)] out BindFromData? data)


being curious. your generator targets netstandard2.1 ? I thought it was limited to 2.0, but never tried to update in a long time

Code generators, if you do not need the integration with the IDE, can run using other versions of dotnet standard: dotnet/docs@fa21a4b

The tldr; they work in the compiler when using the dotnet tools, they will have problems with certain IDEs, specially VS. My approach has been, use the latests to get all the nullability checks etc.. and then make it compatible with the IDE.

src/rgen/Microsoft.Macios.Generator/Attributes/BindFromData.cs

StephaneDelcroix · 2025-01-31T19:20:49Z

src/rgen/Microsoft.Macios.Generator/Attributes/BindFromData.cs

+		Type = type;
+	}
+
+	public BindFromData (string type, string? originalType)


can't you juste use ITypeSymbols instead of strings? ToDisplayString() with the default SymbolFormater scares me a bit...

+1 on being worried. It is a problem I have and I'm leaving it for later in the project.

I want to minimize the size of the structure stored in memory and I want to be able to reduce the number of classes and simplify their tree to reduce the GC pressure during the compilation. Ideally, I would move to reference readonly structures but the API from roslyn does not allow that.

Once we have the tests passing I will profile the generator with the strings and take a different approach. We do know that the bgen code had a HUGE memory usage due to strings (Up to 2Gb)

Co-authored-by: Jonathan Peppers <[email protected]>

mandel-macaque · 2025-02-01T12:09:37Z

Failing tests are unrelated to the changes.

vs-mobiletools-engineering-service2 · 2025-02-01T13:32:49Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T13:34:48Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T13:41:46Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T13:57:57Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T13:58:42Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T13:58:57Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T13:59:06Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T14:20:39Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T14:28:36Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-01T16:17:49Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 112 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5c5febc36c5f33a4e4132f648b2a4c206bef0153 [PR build]

mandel-macaque and others added 2 commits January 31, 2025 08:16

Auto-format source code

6aea0ea

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jan 31, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

StephaneDelcroix reviewed Jan 31, 2025

View reviewed changes

jonathanpeppers approved these changes Jan 31, 2025

View reviewed changes

src/rgen/Microsoft.Macios.Generator/Attributes/BindFromData.cs Outdated Show resolved Hide resolved

StephaneDelcroix approved these changes Jan 31, 2025

View reviewed changes

Update src/rgen/Microsoft.Macios.Generator/Attributes/BindFromData.cs

32e11c8

Co-authored-by: Jonathan Peppers <[email protected]>

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 5c5febc into main Feb 1, 2025
45 of 47 checks passed

mandel-macaque deleted the dev/mandel/rgen-bind-from-attr branch February 1, 2025 12:09



		public static bool TryParse (AttributeData attributeData,
		[NotNullWhen (true)] out BindFromData? data)

[RGen] Implement the BindFrom attribute. #22087

[RGen] Implement the BindFrom attribute. #22087

Conversation

mandel-macaque commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

StephaneDelcroix Jan 31, 2025

Choose a reason for hiding this comment

mandel-macaque Jan 31, 2025

Choose a reason for hiding this comment

StephaneDelcroix Jan 31, 2025

Choose a reason for hiding this comment

mandel-macaque Jan 31, 2025

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Feb 1, 2025

vs-mobiletools-engineering-service2 commented Feb 1, 2025

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Feb 1, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Feb 1, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Feb 1, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Feb 1, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Feb 1, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Feb 1, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Feb 1, 2025

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Feb 1, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Feb 1, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts