Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep compatibility with the development version of pint #341

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Jun 28, 2022

Since pint is now capable of parsing % we don't need the workaround anymore, which allows us to stop using pint's internal API.

I'm not sure about the second failure from #338 (ValueError: Invalid format specifier): I can't reproduce that locally.
Edit: that seems to be a race condition, it will only be raised if we execute tests in parallel.

@keewis keewis changed the title keep compatibility with recent versions of pint keep compatibility with the development version of pint Jun 28, 2022
@dcherian dcherian merged commit ef7534d into xarray-contrib:main Jun 28, 2022
@dcherian
Copy link
Contributor

Thanks!

@keewis keewis deleted the fix-pint-upstream-compat branch June 28, 2022 12:33
@keewis
Copy link
Contributor Author

keewis commented Jun 28, 2022

It seems the version of cf-xarray in CI is 0.1.dev1+g<commit hash>. To fix that, you probably need to pass fetch-depth: 0 to actions/checkout so setuptools-scm can detect the release tags.

At the moment, not fixing this will not cause any issues (besides a slight confusion when reading the logs), but be aware that as soon as a dependency decides to depend on cf-xarray the CI will stop working (we had this issue with xarray and cfgrib).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream-dev pint tests are failing
2 participants