Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
accessor.py
, a few xarray classes are used without their module being explicitly imported. It seems that the latest commits to xarray have modified some import behaviour and it broke cf-xarray. Specifically, it seems that:is not sufficient to import
xr.core.resample
. See https://github.com/pangeo-data/xESMF/runs/7119669567?check_suite_focus=trueThis PR fixes the problem simply by explicitly importing those "wrapped classes".
I'm not sure if this should be considered a breaking change for xarray. If yes, then the fix might be best done there, but I haven't found exactly the source of the bug. It was a lot simpler to do what I did here.