Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov reporting (follow up to #482) #483

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

jsignell
Copy link
Contributor

@jsignell jsignell commented Dec 1, 2023

Sorry about that I missed that codecov also needs to be told not to include tests.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff03ebf) 63.60% compared to head (17cb802) 93.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #483       +/-   ##
===========================================
+ Coverage   63.60%   93.91%   +30.31%     
===========================================
  Files          22       13        -9     
  Lines        4212     1709     -2503     
  Branches      223        0      -223     
===========================================
- Hits         2679     1605     -1074     
+ Misses       1449      104     -1345     
+ Partials       84        0       -84     
Flag Coverage Δ
mypy ?
unittests 93.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsignell
Copy link
Contributor Author

jsignell commented Dec 1, 2023

This looks more like it: https://app.codecov.io/gh/xarray-contrib/cf-xarray/pull/483

@dcherian
Copy link
Contributor

dcherian commented Dec 1, 2023

❤️

@dcherian dcherian merged commit 2648109 into xarray-contrib:main Dec 1, 2023
12 checks passed
@jsignell jsignell deleted the codecov branch December 1, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants