cast units to str
before applying any other preprocessor
#498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to accept integer units of
1
for dimensionless, which is explicitly allowed by the CF conventions (we could, however, pass through objects that are not integers unmodified).Note that
pint
itself doesn't really like the idea of integer units, so this will only work withureg.parse_units(1)
:ureg.Quantity(1, 1)
will raise before any preprocessor is called.