Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide more context to errors #92

Merged
merged 19 commits into from
Apr 24, 2021
Merged

provide more context to errors #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
27bad00
reverse the order of checks in the DimensionalityError constructor
keewis Apr 14, 2021
921b8ee
simplify the str method
keewis Apr 14, 2021
7357bbd
add a custom exception for invalid units
keewis Apr 14, 2021
ec8ffe5
use the new exception to present all invalid units at once
keewis Apr 14, 2021
334ee5b
replace the custom class by a formatter
keewis Apr 14, 2021
5e7fbc2
use the new formatter to collect and present unit errors
keewis Apr 14, 2021
eb60afb
fix a leftover reference to the custom error class
keewis Apr 14, 2021
7dfdfdf
synchronize DataArray quantify with Dataset quantify
keewis Apr 14, 2021
24e75fb
more removing of the custom error classes
keewis Apr 15, 2021
ed06707
fix a bug in reindex and rely on convert_units to raise an error
keewis Apr 15, 2021
2ef45b8
fix most other methods
keewis Apr 16, 2021
61ae453
update whats-new.rst
keewis Apr 16, 2021
02ad1de
fix a link [skip-ci]
keewis Apr 16, 2021
94943f9
explicitly parse the units
keewis Apr 16, 2021
d4e094d
limit the errors caught in quantify to ValueError and UndefinedUnitError
keewis Apr 16, 2021
ff5328d
remove the custom error class
keewis Apr 23, 2021
ebd511e
actually call loc when expecting errors
keewis Apr 23, 2021
4d73a81
also check whether the error for a invalid attribute is properly form…
keewis Apr 23, 2021
d6528d3
rewrite the tests for to
keewis Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ What's new
- rewrite :py:meth:`Dataset.pint.quantify` and :py:meth:`DataArray.pint.quantify`,
to use pint's `parse_units` instead of `parse_expression` (:pull:`40`)
By `Tom Nicholas <https://github.com/TomNicholas>`_.
- ensure the variable which causes the error is explicit if an error occurs in
:py:meth:`Dataset.pint.quantify` (:pull:`43`)
By `Tom Nicholas <https://github.com/TomNicholas>`_.
- ensure the variables which causes the error is explicit if an error occurs in
:py:meth:`Dataset.pint.quantify` and other methods (:pull:`43`, :pull:`91`)
By `Tom Nicholas <https://github.com/TomNicholas>`_ and `Justus Magin <https://github.com/keewis>`_.
- refactor the internal conversion functions (:pull:`56`)
By `Justus Magin <https://github.com/keewis>`_.
- allow converting indexes (except :py:class:`pandas.MultiIndex`) (:pull:`56`)
Expand Down Expand Up @@ -45,7 +45,7 @@ What's new
By `Justus Magin <https://github.com/keewis>`_.
- implement :py:meth:`Dataset.pint.interpolate_na` and :py:meth:`DataArray.pint.interpolate_na` (:pull:`82`).
By `Justus Magin <https://github.com/keewis>`_.
- expose :py:func:`pint_xarray.accessors.setup_registry` as public API (:pull:`89`)
- expose :py:func:`pint_xarray.setup_registry` as public API (:pull:`89`)
By `Justus Magin <https://github.com/keewis>`_.

v0.1 (October 26 2020)
Expand Down
Loading