Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider delete worker task on completion instead of batch deletion #58

Closed
longquanzheng opened this issue Oct 19, 2023 · 0 comments · Fixed by #95
Closed

consider delete worker task on completion instead of batch deletion #58

longquanzheng opened this issue Oct 19, 2023 · 0 comments · Fixed by #95
Labels
enhancement New feature or request perf-optimization

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Oct 19, 2023

Similar to timerTaskProcessor, worker task can also be deleted within the transaction on completion.

This would reduce the chance that worker task re-execute which could cause more database requests.

For example, after completion, if workerTaskQueue got closed before committing/deleting the worker tasks, the same task will be reloaded and executed again.

This will be easier to understand as well -- currently when worker task backoff retry, it will be converted into a timer task(which means the worker task got deleted during processing)

@longquanzheng longquanzheng changed the title consider delete worker task on completion consider delete worker task on completion instead of batch deletion Oct 29, 2023
@duoertai duoertai linked a pull request Nov 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request perf-optimization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant