delete immediate task on completion #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested locally by querying xdb_sys_immediate_tasks |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 65.51% 65.62% +0.10%
==========================================
Files 77 77
Lines 5849 5829 -20
==========================================
- Hits 3832 3825 -7
+ Misses 1775 1761 -14
- Partials 242 243 +1 ☔ View full report in Codecov by Sentry. |
|
we also need to remove the logic of batch delete in immediate_task_queue |
engine/immediate_task_queue.go
Outdated
| @@ -98,7 +97,6 @@ func (w *immediateTaskQueueImpl) Start() error { | |||
| case <-w.pollTimer.FireChan(): | |||
| w.pollAndDispatchAndPrepareNext() | |||
| case <-w.commitTimer.FireChan(): | |||
There was a problem hiding this comment.
I don't think we need the commit timer anymore?
longquanzheng
approved these changes
Nov 16, 2023
duoertai
deleted the
58-consider-delete-worker-task-on-completion-instead-of-batch-deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this pull request?
[Explain why you are making this pull request and what problem it solves.]
What has changed
[Summarize what components of the repo is updated]
[Link to xdb-apis/xdb-golang-sdk PRs if it's on top of any API changes]
How to test this pull request?
[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]
[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first,
without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]
[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR.
After the server PR is merged, merge the integration test in the SDK repo]
Checklist before merge
[ ] If applicable, merge the xdb-apis/xdb-golang-sdk PRs to main branch
[ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch
[ ] Update
go.modto use the commitID of the main branches for xdb-apis/xdb-golang-sdk