clean: purge undocumented and useless editDictionaryCommandLine
#1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1780
There are a few mentions on internet about
editDictionaryCommandLine.But what's the point? If a user wants to edit DSL/XDXF files directly, then just open it with an editor, there is little to no reason to open it via GD and waste time to discover this thing.
It is not fully implemented (if it shows up and it doesn't work, user cannot know why it doesn't work, like #1780).
To enable it, user have to edit
config'seditDictionaryCommandLinewith${editor name} %GDDICT%. This is impossible to be discovered.