fix: ctrl+F crashes when last tab is closed #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlebantongying
changed the title
shenlebantongying
force-pushed
the
fix/ctrl_f-crash
branch
from
3565872 to
0c1a0cd
Compare
shenlebantongying
force-pushed
the
fix/ctrl_f-crash
branch
from
0c1a0cd to
79dae65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root issue is
The 3rd
thisis mainwinidow, while theconnectis only valid during the currentview.fix https://forum.freemdict.com/t/topic/11495/3513
The workaround for scanpopup is not invalidated by this PR.