Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: simplify loadDictionaries & Initializing dialog's showInitialy parameter #1833

Merged
merged 2 commits into from
Oct 18, 2024
Merged

clean: simplify loadDictionaries & Initializing dialog's showInitialy parameter #1833

merged 2 commits into from
Oct 18, 2024

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Oct 18, 2024 •
edited
Loading

Amend 9ae4e57

@shenlebantongying shenlebantongying force-pushed the clean/loaddict branch 2 times, most recently from 5e7b227 to 239f83b Compare October 18, 2024 01:37
@shenlebantongying shenlebantongying changed the title clean: remove 2 paramaters loadDictionaries's showInitialy and Initializing's showOnStartup clean: remove loadDictionaries → showInitialy & Initializing →showOnStartup Oct 18, 2024
@xiaoyifang
Copy link
Owner

Initializing Dialog? Isn't this dialog which shows the index processing .
When users open the gd-ng for the first time , it will make headword indexing . All the operations will take time.

@shenlebantongying shenlebantongying marked this pull request as draft October 18, 2024 02:19
@shenlebantongying shenlebantongying marked this pull request as ready for review October 18, 2024 02:22
@shenlebantongying
Copy link
Collaborator Author

shenlebantongying commented Oct 18, 2024 •
edited
Loading

The showInitialy (which will be passed down to Initializing as showOnStartup) is always true, except this place:

However, it does nothing. Because immediately after the initialization of Initializing dialog the loading/initializing signals make the dialog to show up.

@shenlebantongying shenlebantongying force-pushed the clean/loaddict branch 2 times, most recently from 06067ef to a51c843 Compare October 18, 2024 02:40
@shenlebantongying shenlebantongying changed the title clean: remove loadDictionaries → showInitialy & Initializing →showOnStartup clean: simplify loadDictionaries & Initializing dialog's showInitialy parameter Oct 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@shenlebantongying
Copy link
Collaborator Author

There is no functional difference before and after, but loadDictionaries now don't have a weird showInitialy to control the internal dialog's initial state.

Maybe we should move the dialog out of the loadDictionaries method so that it can be used without GUI for staff like #1826

@shenlebantongying shenlebantongying merged commit 9f13188 into xiaoyifang:staged Oct 18, 2024
9 checks passed
@shenlebantongying shenlebantongying deleted the clean/loaddict branch October 18, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenlebantongying @xiaoyifang