Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: rewrite the logic of determine the existence of audio link #1860

Merged
merged 13 commits into from
Oct 24, 2024

Conversation

xiaoyifang
Copy link
Owner

No description provided.

@shenlebantongying
Copy link
Collaborator

It seems the gdAudioLinks in the gd-builtin.js should be deleted after this change?

@xiaoyifang
Copy link
Owner Author

It seems the gdAudioLinks in the gd-builtin.js should be deleted after this change?

OK

@xiaoyifang xiaoyifang enabled auto-merge (squash) October 24, 2024 13:24
@xiaoyifang xiaoyifang merged commit 01b9814 into staged Oct 24, 2024
10 checks passed
@xiaoyifang xiaoyifang deleted the opt/audioLink branch October 24, 2024 13:32
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants