Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: rearrange some code execution order #1906

Merged
merged 1 commit into from
Nov 6, 2024
Merged

opt: rearrange some code execution order #1906

merged 1 commit into from
Nov 6, 2024

Conversation

xiaoyifang
Copy link
Owner

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

shenlebantongying
shenlebantongying approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@shenlebantongying shenlebantongying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@xiaoyifang xiaoyifang merged commit 8d0859b into staged Nov 6, 2024
10 of 11 checks passed
@xiaoyifang xiaoyifang deleted the opt/articleview-loadfinish branch November 6, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenlebantongying shenlebantongying shenlebantongying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyifang @shenlebantongying