clean: apply clang-tidy's modernize-use-using (replace most typedef)
#1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlebantongying
changed the title
modernize-use-using (replace most typedef`)modernize-use-using (replace most typedef)
shenlebantongying
force-pushed
the
clean/tidy-using-using
branch
2 times, most recently
from
727aba0 to
1fcf48b
Compare
shenlebantongying
force-pushed
the
clean/tidy-using-using
branch
from
1fcf48b to
d15081e
Compare
Comment on lines
-118
to
132
| typedef struct | ||
| struct bgl_block | ||
| { | ||
| unsigned type; | ||
| unsigned length; | ||
| char * data; | ||
| } bgl_block; | ||
| }; | ||
|
|
||
| typedef struct | ||
| struct bgl_entry | ||
| { | ||
| std::string headword; | ||
| std::string definition; | ||
| std::string displayedHeadword; | ||
| std::vector< std::string > alternates; | ||
| } bgl_entry; | ||
| }; | ||
|
|
There was a problem hiding this comment.
In C++, there is no need to typedef again. The struct name can be directly used.
https://learn.microsoft.com/en-us/cpp/cpp/struct-cpp?view=msvc-170#using-a-structure
shenlebantongying
changed the title
modernize-use-using (replace most typedef)modernize-use-using (replace most typedef)
shenlebantongying
force-pushed
the
clean/tidy-using-using
branch
from
2cae13f to
fb45d2e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel
usingis a straight upgrade oftypedefespecially for long type names.There is only 2
typedefleft because that file is currently compiled as C.