Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deploy qt translations for macOS #1918

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix: deploy qt translations for macOS #1918

merged 1 commit into from
Nov 7, 2024

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Nov 7, 2024 •
edited
Loading

close #1917

depends on #1916

method is using qt.conf to set a QLibraryInfo::path( QLibraryInfo::TranslationsPath )

This adds 7Mb "bloat" 😅

@shenlebantongying shenlebantongying merged commit f8f62ef into xiaoyifang:staged Nov 7, 2024
7 checks passed
@shenlebantongying shenlebantongying deleted the fix/mac_deploy-traslationsss branch November 7, 2024 01:33
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@shenlebantongying shenlebantongying mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qt & webengine 's built in translations are not deployed on macOS
1 participant
@shenlebantongying