Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macOS -> replace the tray icon with a dock menu #1934

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Nov 11, 2024


After this change:

The toggle clipboard monitoring is moved to the dock menu.

To toggling visibility using dock icon: "Click" to bring up and "Option+Click" to hide. Note that "Option+click" may also hide other staffs, a weird shortcut.


Pretty sure this will break someone's habit, however

  • The tray icon has little value on macOS because macOS's dock has the capability of having custom menu items
  • Bugs, as in the issues mentioned. They all require macOS specific code that may lock related code in place for future because nobody knows Qt and macOS programming at the same time.

Is there fixes? Yes, but actually no.

(Apple don't use the terminology "tray icons", it is "Menu Extra" BTW. -> from Apple's HIG https://developer.apple.com/design/human-interface-guidelines/the-menu-bar#Menu-bar-extras).

I think this is the best way forward with only downside of breaks some existing users, hopefully they can adapt and hopefully using dock menu isn't hard.

@shenlebantongying shenlebantongying force-pushed the fix/replace-macos-tray-with-dock branch from d7c0010 to 73b472a Compare November 11, 2024 07:15
Copy link

@shenlebantongying shenlebantongying merged commit 1e3b22e into xiaoyifang:staged Nov 11, 2024
8 checks passed
@shenlebantongying shenlebantongying deleted the fix/replace-macos-tray-with-dock branch November 11, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants