clean: simplify macOS hotkey mapping code #1942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's merge this in another day,
Chop related code to half.
This region of code looked scary because the first line assumes everyone uses English keyboard.
So, the next line patches it by copying current input source -> TISCopyCurrentKeyboardInputSource
But japanese keyboard is slightly different, so it got patched again with TISCopyCurrentKeyboardLayoutInputSource
Just uses the last one
TISCopyCurrentKeyboardLayoutInputSource
, all code are no longer needed.Also change mappping to a vector instead of
calloc
.