clean: delete most Qt5 & <=6.3 conditional compiled code (QT_VERSION_CHECK macro)
#1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlebantongying
force-pushed
the
clean/no-qt5-condi
branch
from
d761cdf to
f282507
Compare
Comment on lines
-42
to
-44
| #if ( QT_VERSION < QT_VERSION_CHECK( 6, 0, 0 ) || QT_VERSION > QT_VERSION_CHECK( 6, 3, 0 ) ) | ||
| page->triggerAction( QWebEnginePage::InspectElement ); | ||
| #endif |
There was a problem hiding this comment.
The only one with Qt>6.3 for some reason. The Qt6.2 also have it.
| @@ -23,18 +19,7 @@ static QAudioFormat format( int sampleRate, int channelCount ) | |||
|
|
|||
| out.setSampleRate( sampleRate ); | |||
| out.setChannelCount( channelCount ); | |||
| #if QT_VERSION < QT_VERSION_CHECK( 6, 0, 0 ) | |||
| out.setByteOrder( QAudioFormat::LittleEndian ); | |||
| out.setCodec( QLatin1String( "audio/pcm" ) ); | |||
There was a problem hiding this comment.
PCM, commenly used in .wav -> https://en.wikipedia.org/wiki/Pulse-code_modulation
shenlebantongying
changed the title
QT_VERSION_CHECK macro)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just wanted to delete Qt5 branch code, but found Qt6≤3 branches aren't really useful either.
The
hotkeywarpper.cc/hharen't touched because I am not on windows/Linux as of now.Plus minor
#includecleanup.