clean: fix some issues found by the code analysis of Visual Studio #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/dict/xdxf2html.cc
Outdated
Comment on lines
104
to
106
| } | ||
| // Fall-through | ||
|
|
||
| [[fallthrough]]; | ||
| default: |
There was a problem hiding this comment.
Interesting one.
Comment replaced by cpp17 standard attribute :)
shenlebantongying
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the Visual Studio's Analyze → Run code analyze button is just rebuilding the project, then collect warnings.
Edit: Actually, I don't know what's the rule it follows. It seems CMake (?) project cannot configure it as written in VS's doc. The panel is blank for me.
https://learn.microsoft.com/en-us/cpp/code-quality/quick-start-code-analysis-for-c-cpp?view=msvc-170
This fixes all the default warnings.
Mostly uninitialized variables. Initialize everything religiously.