Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: delete useless fopen style mode char* API from File::Index #1968

Merged
merged 1 commit into from
Nov 20, 2024
Merged

clean: delete useless fopen style mode char* API from File::Index #1968

merged 1 commit into from
Nov 20, 2024

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Nov 20, 2024 •
edited
Loading

They are useless ever since the original GD.

Stop parsing this 2 char str for nothing.

Depends on #1965

@shenlebantongying shenlebantongying enabled auto-merge (squash) November 20, 2024 03:53
@shenlebantongying shenlebantongying merged commit fa9ad2f into xiaoyifang:staged Nov 20, 2024
7 checks passed
@shenlebantongying shenlebantongying deleted the clean/idxfile-no-str branch November 20, 2024 03:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@xiaoyifang
Copy link
Owner

xiaoyifang commented Nov 20, 2024 •
edited
Loading

'rb' equals ReadOnly + Binary , from the code ,it should be used

@shenlebantongying
Copy link
Collaborator Author

There is no flag for binary in Qt.

The original code merely set it then cancel the Text flag 😅

@xiaoyifang
Copy link
Owner

yes,
in addition.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenlebantongying @xiaoyifang