Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: generally improve cmake build script #1983

Merged

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Nov 22, 2024

  • split packaging code of three platforms into separate files
  • add or correct comments
  • using PkgConfig as much as possible
  • delete outdated macros
  • no double negation #ifndef NO_SOMETHING (Weird inconsistency inherited from the original GD, flag -> no_something=OFF is cringe.)
  • merge taget_compile_defintitions
  • misc

* split packaging code of three platforms into separate files
* add and correct comments
* using PkgConfig as much as possible
* delete outdated macros
@shenlebantongying shenlebantongying merged commit 5406b30 into xiaoyifang:staged Nov 22, 2024
8 checks passed
@shenlebantongying shenlebantongying deleted the dev/cleanup-cmake branch November 22, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant