Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge some encoding and encoding names related code #1990

Merged

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Nov 24, 2024

Now, Iconv reuses Text's encoding names.

@shenlebantongying shenlebantongying enabled auto-merge (squash) November 24, 2024 06:25
@shenlebantongying shenlebantongying merged commit dda91a3 into xiaoyifang:staged Nov 24, 2024
7 checks passed
@shenlebantongying shenlebantongying deleted the refactor/merge-encoding branch November 24, 2024 06:32
@xiaoyifang
Copy link
Owner

maybe. use https://doc.qt.io/qt-6.2/qstringconverter.html#Encoding-enum directly .
and avoid all the conversion.

@shenlebantongying
Copy link
Collaborator Author

There are two issues 1) we need a few more encoding names 2) In a few places, the enum's underlying number is written into the index files.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants