clean: limit QHotkeyApplication::(un)registerWrapper to Windows only #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Installing hotkey interacts with the hotkeywrapper directly goldendict-ng/src/ui/mainwindow.cc Line 2958 in 7eb0648 |
shenlebantongying
force-pushed
the
clean/qhka-ureg
branch
from
db6677e to
eb1443c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These stuffs serve no purpose except for Windows's
nativeEventFilter.AFAIK, it is also unnecessary for Windows too, because only one "wrapper" is ever needed. However, right now I don't have access to a Windows machine.
The introduction of
nativeEventFilter, which was called aswinEventFilter, in Original commit doesn't explain anything goldendict/goldendict@0b87435#diff-55edcc575deee8d79439ced3ef499d0a7369bff2be1717395fd5fab7128f5db5R204Tested on Linux.