refactor: remove DataCommitter interface from QHotkeyApplication
#1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlebantongying
force-pushed
the
clean/rm-data-comitter
branch
from
0b36d03 to
57e3b05
Compare
shenlebantongying
force-pushed
the
clean/rm-data-comitter
branch
from
1f17ece to
f0b5d6f
Compare
shenlebantongying
changed the title
DataCommitter interface from QHotkeyApplication
|
xiaoyifang
reviewed
Nov 26, 2024
| [ &m ]( QSessionManager & ) { | ||
| m.commitData(); | ||
| }, | ||
| Qt::DirectConnection ); |
There was a problem hiding this comment.
any difference between DirectConnection and default?
There was a problem hiding this comment.
I don't think so, app and m lives in the same thread, so the default would be DirectionConnection anyway.
But, the doc have a big note there, so I didn't delete it :)
https://doc.qt.io/qt-6/qguiapplication.html#commitDataRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original GD's author probably wants to invent a mechanism.
He wants objects to manage themselves, implement a "DataCommitter" and register themselves to a list, so that before exiting, they will all be saved.
However, MainWindow's commitData is the only thing that do the work for such long time.
Let's just reduce the whole thing into simply
QObject::connnect.