xkbcomp/expr: remove unused ExprResolveKeyCode #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was added in commit 4e22851. But that commit also changed the grammar: -KeyNameDecl : KeyName EQUALS Expr SEMI +KeyNameDecl : KeyName EQUALS KeyCode SEMI i.e. while before you could write <AE01> = 9+1; now this is a syntax error, an integer literal is expected. I'm not sure if it was intended to remove this ability. In any case, this rendered `ExprResolveKeyCode` useless since there's no longer an expression to evaluate, and after some refactoring it went unused. Even if we choose to restore Expr here, I don't see a reason for the specialized function over `ExprResolveInteger` except the type (which we should probably widen from int to int64_t...). So remove it. Signed-off-by: Ran Benita <[email protected]>
What it says mostly no longer holds, I think it's more confusing than helpful now. Signed-off-by: Ran Benita <[email protected]>
wismill
approved these changes
Feb 7, 2025
|
Ah missed it sorry! The first two commits from #605 look good to me, if you'd like to cherry pick them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was added in commit 4e22851. But that commit also changed the grammar:
i.e. while before you could write
now this is a syntax error, an integer literal is expected. I'm not sure if it was intended to remove this ability. In any case, this rendered
ExprResolveKeyCodeuseless since there's no longer an expression to evaluate, and after some refactoring it went unused.Even if we choose to restore Expr here, I don't see a reason for the specialized function over
ExprResolveIntegerexcept the type (which we should probably widen from int to int64_t...). So remove it.