Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: JWK Migration #115

Merged
merged 5 commits into from
Aug 24, 2022
Merged

FR: JWK Migration #115

merged 5 commits into from
Aug 24, 2022

Conversation

denopink
Copy link
Contributor

Implements #113

What's included:

@denopink denopink added enhancement improvement or small functionality added to an existing feature jwk migration issues related to the jwk migration labels Aug 17, 2022
@denopink denopink requested review from johnabass and renaz6 August 17, 2022 15:30
@denopink denopink self-assigned this Aug 17, 2022
@denopink denopink marked this pull request as draft August 17, 2022 15:30
@codecov
Copy link

codecov bot commented Aug 17, 2022 •
edited
Loading

Codecov Report

Merging #115 (0d7dbd4) into main (e79d324) will not change coverage.
The diff coverage is n/a.

❗ Current head 0d7dbd4 differs from pull request most recent head 8921ee7. Consider uploading reports for the commit 8921ee7 to get more accurate results

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files          13       13           
  Lines         663      663           
=======================================
  Hits          547      547           
  Misses        102      102           
  Partials       14       14
Flag Coverage Δ
unittests 82.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
service.go 75.64% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@denopink denopink marked this pull request as ready for review August 18, 2022 09:40
renaz6
renaz6 reviewed Aug 18, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@denopink denopink force-pushed the denopink/feature/jwk-migration branch from 1f9d2ff to 4bf0817 Compare August 24, 2022 18:29
@denopink denopink enabled auto-merge August 24, 2022 18:36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@denopink denopink merged commit 0f35d7a into main Aug 24, 2022
@denopink denopink deleted the denopink/feature/jwk-migration branch August 24, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaz6 renaz6 renaz6 approved these changes

@johnabass johnabass Awaiting requested review from johnabass

Assignees

@denopink denopink

Labels
enhancement improvement or small functionality added to an existing feature jwk migration issues related to the jwk migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denopink @renaz6