Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved code, exported some helper functions #94

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

kristinapathak
Copy link
Contributor

Exported helper functions related to InternalWebhooks, allowing for more flexibility in our applications.

@kristinapathak kristinapathak added the enhancement improvement or small functionality added to an existing feature label Mar 25, 2022
@kristinapathak kristinapathak requested a review from mtrinh11 March 25, 2022 17:38
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.1% 71.1% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #94 (e35d700) into main (884ab5a) will not change coverage.
The diff coverage is 64.28%.

❗ Current head e35d700 differs from pull request most recent head 8d1d010. Consider uploading reports for the commit 8d1d010 to get more accurate results

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files          10       11    +1     
  Lines         486      486           
=======================================
  Hits          397      397           
  Misses         78       78           
  Partials       11       11           
Impacted Files Coverage Δ
internalWebhook.go 63.15% <63.15%> (ø)
service.go 32.25% <66.66%> (-11.75%) ⬇️
transport.go 94.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884ab5a...8d1d010. Read the comment docs.

@kristinapathak kristinapathak merged commit 345c320 into main Mar 25, 2022
@kristinapathak kristinapathak deleted the export-funcs branch March 25, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants