Update code for changes in rehasher and sd metrics #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 58.44% 58.14% -0.30%
==========================================
Files 14 14
Lines 977 982 +5
==========================================
Hits 571 571
- Misses 397 402 +5
Partials 9 9
Continue to review full report at Codecov.
|
johnabass
approved these changes
May 5, 2020
johnabass
requested changes
May 5, 2020
| @@ -54,6 +54,10 @@ var ( | |||
| BuildTime = "undefined" | |||
| ) | |||
|
|
|||
| func setupDefaultConfigValues(v *viper.Viper) { | |||
| v.SetDefault(RehasherServicesConfigKey, []string{applicationName}) | |||
There was a problem hiding this comment.
When doing this, something that helps avoid later errors is to use SetTypeByDefaultValue(true):
https://pkg.go.dev/github.com/spf13/viper?tab=doc#SetTypeByDefaultValue
johnabass
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.