Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require a header that's not used #135

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

joe94
Copy link
Member

@joe94 joe94 commented May 21, 2020

No description provided.

@joe94 joe94 self-assigned this May 21, 2020
@joe94 joe94 added the bug label May 21, 2020
@joe94 joe94 linked an issue May 21, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #135 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   58.14%   58.20%   +0.05%     
==========================================
  Files          14       14              
  Lines         982      981       -1     
==========================================
  Hits          571      571              
+ Misses        402      401       -1     
  Partials        9        9              
Impacted Files Coverage Δ
primaryHandler.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4547aa...9d2d4c9. Read the comment docs.

@joe94 joe94 merged commit c65e045 into master May 26, 2020
@joe94 joe94 deleted the bugfix/headerNotRequired branch May 26, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

talaria requires header but does not validate/use it
3 participants