Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use query library which doesn't modify input map #137

Merged
merged 6 commits into from
Jun 30, 2020
Merged

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jun 11, 2020

No description provided.

@joe94 joe94 self-assigned this Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #137 into master will decrease coverage by 0.43%.
The diff coverage is 61.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   58.20%   57.77%   -0.44%     
==========================================
  Files          14       14              
  Lines         981      978       -3     
==========================================
- Hits          571      565       -6     
- Misses        401      404       +3     
  Partials        9        9              
Impacted Files Coverage Δ
primaryHandler.go 0.00% <0.00%> (ø)
middleware.go 18.18% <28.57%> (+18.18%) ⬆️
deviceStatus.go 49.27% <66.66%> (ø)
deviceAccess.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd3a3c...de1a16f. Read the comment docs.

@joe94 joe94 linked an issue Jun 12, 2020 that may be closed by this pull request
@joe94 joe94 requested review from johnabass, gargidb, kristinapathak and a team June 12, 2020 00:53
@joe94 joe94 merged commit c45a32c into master Jun 30, 2020
@joe94 joe94 deleted the feature/metadata branch June 30, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants