Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump webpa-common v1.10.5 #147

Merged
merged 4 commits into from
Jul 24, 2020
Merged

bump webpa-common v1.10.5 #147

merged 4 commits into from
Jul 24, 2020

Conversation

kcajmagic
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #147 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   57.77%   57.77%           
=======================================
  Files          14       14           
  Lines         978      978           
=======================================
  Hits          565      565           
  Misses        404      404           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f271c...0e27d41. Read the comment docs.

@@ -375,10 +375,6 @@ service:
# address tells consul where to contact the service.
address: (( concat "http://" server domain ))

# scheme tells consul what scheme to use to contact the service.
# This is used with the address for calls to this server.
scheme: "http"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we dropping support for this?

@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
## [Unreleased]

## [v0.5.8]
- bumped webpa-common to fix consul last wait index and AllDatacenters [#147](https://github.com/xmidt-org/talaria/pull/147)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- bumped webpa-common to fix consul last wait index and AllDatacenters [#147](https://github.com/xmidt-org/talaria/pull/147)
- Bumped webpa-common to fix consul last wait index and AllDatacenters. [#147](https://github.com/xmidt-org/talaria/pull/147)

@kcajmagic kcajmagic merged commit 46e52dc into xmidt-org:main Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants