added RawAttributes interface #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulnerable Libraries (2)
More info on how to fix Vulnerable Libraries in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
kcajmagic
suggested changes
Dec 4, 2020
middleware.go
Outdated
| @@ -23,7 +23,9 @@ func DeviceMetadataMiddleware(delegate http.Handler) http.Handler { | |||
| metadata.SetSessionID(ksuid.New().String()) | |||
|
|
|||
| if auth, ok := bascule.FromContext(ctx); ok { | |||
| metadata.SetClaims(auth.Token.Attributes().FullView()) | |||
| if tokenAttributes, ok := auth.Token.Attributes().(rawAttributes); ok { | |||
There was a problem hiding this comment.
Is this meant to be casting to the interface or the struct? Currently this is the struct, not the interface.
Also - what should happen if it isn't ok? It's fine to continue after we find a bascule token that wasn't a RawAttributes like we expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for talaria to get all of a JWT's claims from an Attribute.
Fixes #161