Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry changes with optional tracing #178

Merged
merged 5 commits into from
May 5, 2021
Merged

Conversation

utsavbatra5
Copy link
Contributor

No description provided.

@utsavbatra5
Copy link
Contributor Author

Hi @joe94 can you please review this?

@joe94
Copy link
Member

joe94 commented May 3, 2021

@utsavbatra5, taking a look at this today 👍

control.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
deploy/packaging/talaria_spruce.yaml Outdated Show resolved Hide resolved
talaria.yaml Outdated Show resolved Hide resolved
@joe94
Copy link
Member

joe94 commented May 3, 2021

Hey @utsavbatra5, I applied some suggestions. Let me know if they look good to you 👍
Also, I see some unit tests failing. Could you address those? Thanks!

@joe94 joe94 linked an issue May 3, 2021 that may be closed by this pull request
@utsavbatra5
Copy link
Contributor Author

Hi @joe thanks for reviewing and the commit. I have created a new commit for handling the failure of unit test cases.

WRPHandler.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #178 (b30bb90) into main (c6d129d) will decrease coverage by 1.95%.
The diff coverage is 4.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   56.86%   54.91%   -1.96%     
==========================================
  Files          16       16              
  Lines         932      967      +35     
==========================================
+ Hits          530      531       +1     
- Misses        392      424      +32     
- Partials       10       12       +2     
Impacted Files Coverage Δ
control.go 0.00% <0.00%> (ø)
main.go 0.00% <0.00%> (ø)
primaryHandler.go 0.00% <0.00%> (ø)
WRPHandler.go 90.54% <40.00%> (-3.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d129d...b30bb90. Read the comment docs.

@joe94 joe94 merged commit d86b9d6 into xmidt-org:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional OpenTelemetry tracing
2 participants