Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't include authorization header in logs #181

Merged
merged 2 commits into from
Jun 11, 2021
Merged

don't include authorization header in logs #181

merged 2 commits into from
Jun 11, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jun 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 10, 2021 •
edited
Loading

Codecov Report

Merging #181 (331f91e) into main (843dfa7) will increase coverage by 0.32%.
The diff coverage is 35.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   54.91%   55.23%   +0.32%     
==========================================
  Files          16       17       +1     
  Lines         967      974       +7     
==========================================
+ Hits          531      538       +7     
  Misses        424      424              
  Partials       12       12
Impacted Files Coverage Δ
primaryHandler.go 0.00% <0.00%> (ø)
basculeLogging.go 43.75% <43.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 843dfa7...331f91e. Read the comment docs.

@joe94 joe94 linked an issue Jun 10, 2021 that may be closed by this pull request
Remove Authorization Header from logged headers #180
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

35.0% 35.0% Coverage
0.0% 0.0% Duplication

@joe94 joe94 merged commit 57c3972 into main Jun 11, 2021
@joe94 joe94 deleted the bugfix/authHeaderLogging branch June 11, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Authorization Header from logged headers
2 participants
@joe94 @kristinapathak