Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/device access check configurable #184

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Feature/device access check configurable #184

merged 3 commits into from
Jul 8, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jul 8, 2021

No description provided.

@joe94 joe94 linked an issue Jul 8, 2021 that may be closed by this pull request
Allow device access check type to be modified in spruce config #183
Closed
@joe94 joe94 requested a review from kristinapathak July 8, 2021 19:42
@codecov
Copy link

codecov bot commented Jul 8, 2021 •
edited
Loading

Codecov Report

Merging #184 (a08c649) into main (57c3972) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   55.23%   55.23%           
=======================================
  Files          17       17           
  Lines         974      974           
=======================================
  Hits          538      538           
  Misses        424      424           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c3972...a08c649. Read the comment docs.

@joe94 joe94 merged commit dace2f9 into main Jul 8, 2021
@joe94 joe94 deleted the feature/deviceAccessCheckConfigurable branch July 8, 2021 19:43
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow device access check type to be modified in spruce config
2 participants
@joe94 @kristinapathak