Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/inbound request timeout #187

Merged
merged 8 commits into from
Aug 21, 2021
Merged

Bugfix/inbound request timeout #187

merged 8 commits into from
Aug 21, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jul 27, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #187 (371acf5) into main (58313c1) will increase coverage by 0.37%.
The diff coverage is 27.77%.

❗ Current head 371acf5 differs from pull request most recent head d9037c9. Consider uploading reports for the commit d9037c9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   56.89%   57.26%   +0.37%     
==========================================
  Files          17       17              
  Lines        1074     1067       -7     
==========================================
  Hits          611      611              
+ Misses        451      444       -7     
  Partials       12       12              
Impacted Files Coverage Δ
basculeLogging.go 40.00% <0.00%> (ø)
control.go 0.00% <0.00%> (ø)
deviceAccess.go 100.00% <ø> (ø)
deviceStatus.go 49.27% <ø> (ø)
dispatcher.go 89.32% <ø> (ø)
main.go 0.00% <0.00%> (ø)
metrics.go 100.00% <ø> (ø)
middleware.go 10.52% <ø> (ø)
outbounder.go 87.73% <ø> (ø)
primaryHandler.go 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58313c1...d9037c9. Read the comment docs.

@joe94 joe94 linked an issue Jul 27, 2021 that may be closed by this pull request
@joe94 joe94 self-assigned this Jul 27, 2021
@joe94 joe94 requested a review from johnabass July 27, 2021 23:53
@joe94 joe94 marked this pull request as ready for review July 27, 2021 23:57
@joe94 joe94 force-pushed the bugfix/inboundRequestTimeout branch from 8313485 to db35a83 Compare August 21, 2021 02:26
@joe94 joe94 merged commit f104d3f into main Aug 21, 2021
@joe94 joe94 deleted the bugfix/inboundRequestTimeout branch August 21, 2021 02:44
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout is default 120 seconds for all incoming Http requests.
3 participants