Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed authkey from string splice to single string value #188

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

mtrinh11
Copy link
Contributor

No description provided.

@mtrinh11
Copy link
Contributor Author

fixes #124

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #188 (2829f92) into main (90e951c) will increase coverage by 1.65%.
The diff coverage is 85.71%.

❗ Current head 2829f92 differs from pull request most recent head 935bd7d. Consider uploading reports for the commit 935bd7d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   55.23%   56.89%   +1.65%     
==========================================
  Files          17       17              
  Lines         974     1074     +100     
==========================================
+ Hits          538      611      +73     
- Misses        424      451      +27     
  Partials       12       12              
Impacted Files Coverage Δ
dispatcher.go 89.32% <83.33%> (+0.89%) ⬆️
outbounder.go 87.73% <100.00%> (+0.23%) ⬆️
basculeLogging.go 40.00% <0.00%> (-3.75%) ⬇️
rawAttributes.go 71.42% <0.00%> (-3.58%) ⬇️
main.go 0.00% <0.00%> (ø)
binOp.go 100.00% <0.00%> (ø)
checks.go 100.00% <0.00%> (ø)
control.go 0.00% <0.00%> (ø)
metrics.go 100.00% <0.00%> (ø)
urlFilter.go 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e951c...935bd7d. Read the comment docs.

@mtrinh11 mtrinh11 merged commit 3df660f into xmidt-org:main Aug 13, 2021
@mtrinh11 mtrinh11 deleted the issue124 branch August 13, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants