Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed http scheme from address #190

Merged
merged 1 commit into from
Aug 27, 2021
Merged

removed http scheme from address #190

merged 1 commit into from
Aug 27, 2021

Conversation

Sachin4403
Copy link
Contributor

Due to HTTP scheme in consul.registrations.address the rehasher was not working as expected. after removing the HTTP scheme it working fine.

Same is discussed in xmidt-org/xmidt#54

@Sachin4403
Copy link
Contributor Author

Hi @joe94,
Could you please merge this to the main branch?

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #190 (04453bd) into main (58313c1) will not change coverage.
The diff coverage is n/a.

❗ Current head 04453bd differs from pull request most recent head 57df725. Consider uploading reports for the commit 57df725 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   56.89%   56.89%           
=======================================
  Files          17       17           
  Lines        1074     1074           
=======================================
  Hits          611      611           
  Misses        451      451           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58313c1...57df725. Read the comment docs.

@joe94 joe94 merged commit 76e20f0 into xmidt-org:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants