Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed handler for devices with auths, added log #196

Merged
merged 2 commits into from
Dec 8, 2021
Merged

fixed handler for devices with auths, added log #196

merged 2 commits into from
Dec 8, 2021

Conversation

kristinapathak
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #196 (170a78a) into main (abd48d9) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   56.62%   56.31%   -0.32%     
==========================================
  Files          17       17              
  Lines        1079     1085       +6     
==========================================
  Hits          611      611              
- Misses        456      462       +6     
  Partials       12       12
Impacted Files Coverage Δ
middleware.go 8.00% <0.00%> (-2.53%) ⬇️
primaryHandler.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd48d9...170a78a. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

johnabass
johnabass approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kristinapathak kristinapathak merged commit 9f2c489 into main Dec 8, 2021
@kristinapathak kristinapathak deleted the fix-endpoint branch December 8, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnabass johnabass johnabass approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristinapathak @johnabass