Fix docker-compose dev env #295
Conversation
|
Marcia Piccione seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 60.83% 60.83%
=======================================
Files 18 18
Lines 1527 1527
=======================================
Hits 929 929
Misses 584 584
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
.release/docker/talaria_spruce.yaml
Outdated
| jwtValidator: | ||
| keys: | ||
| Factory: | ||
| uri: (( grab $THEMIS_ENDPOINT || "http://themis:6500/keys/docker" )) | ||
| purpose: 0 | ||
| updateInterval: 24h | ||
| Config: | ||
| Resolve: | ||
| Template: (( grab $THEMIS_ENDPOINT || "http://themis:6500/keys/docker" )) | ||
| Refresh: | ||
| Sources: | ||
| - URI: (( grab $THEMIS_ENDPOINT || "http://themis:6500/keys/docker" )) | ||
| Leeway: 0 |
There was a problem hiding this comment.
the uri should match this structure "localhost:6500/keys/{keyID}", not sure what "http://themis:6500/keys/docker" refers to
There was a problem hiding this comment.
"http://themis:6500/keys/docker" probably should be "http://themis:6500/keys/{keyID}"
There was a problem hiding this comment.
within a docker-compose network, you can refer to other processes by container name (e.g. themis, petasos, etc..). For this particular environment, the key name is "docker" as defined in the dev (docker) yaml file for themis.
There was a problem hiding this comment.
- structure comment to consider https://github.com/xmidt-org/talaria/pull/295/files#r1122074735
- complete this Fix docker-compose dev env #295 (comment)
Otherwise, lgtm
|
@piccione99 don't forget to complete this #295 (comment) |
|
Kudos, SonarCloud Quality Gate passed!
|
the talaria config template file under the .releases directory was out of date for the current version of bascule.