Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zap logger and bascule helper package #315

Merged
merged 8 commits into from
Jun 14, 2023
Merged

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented May 25, 2023

@maurafortino maurafortino added the webpa-common archival/deprecation work related to the archival & deprecation of webpa-common label May 25, 2023
@maurafortino maurafortino self-assigned this May 25, 2023
@guardrails
Copy link

guardrails bot commented May 25, 2023

⚠️ We detected 3 security issues in this pull request:

Vulnerable Libraries (3)
Severity Details
N/A pkg:golang/github.com/xmidt-org/webpa-common/[email protected]@v2.1.3 - no patch available
N/A pkg:golang/github.com/xmidt-org/[email protected]@v0.2.2 - no patch available
N/A pkg:golang/github.com/xmidt-org/[email protected]@v0.11.5 - no patch available

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@maurafortino maurafortino marked this pull request as draft May 25, 2023 17:50
@maurafortino maurafortino marked this pull request as ready for review May 26, 2023 13:48
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #315 (3ecdb07) into main (54a3548) will decrease coverage by 0.50%.
The diff coverage is 31.19%.

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   60.83%   60.33%   -0.50%     
==========================================
  Files          18       18              
  Lines        1527     1533       +6     
==========================================
- Hits          929      925       -4     
- Misses        584      594      +10     
  Partials       14       14              
Flag Coverage Δ
unittests 60.33% <31.19%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
basculeLogging.go 20.93% <0.00%> (-21.93%) ⬇️
control.go 0.00% <0.00%> (ø)
main.go 0.00% <0.00%> (ø)
middleware.go 7.69% <0.00%> (+0.79%) ⬆️
primaryHandler.go 0.00% <0.00%> (ø)
outbounder.go 85.81% <71.42%> (+0.10%) ⬆️
WRPHandler.go 84.84% <75.00%> (+0.15%) ⬆️
workerPool.go 90.47% <80.00%> (-0.23%) ⬇️
ackDispatcher.go 96.00% <83.33%> (ø)
deviceAccess.go 100.00% <100.00%> (ø)
... and 1 more

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just had a repeating question about xcontext.Populate.

Cheers! 🍻

control.go Show resolved Hide resolved
primaryHandler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounded like you figured out the xcontext.Populate comment, so lgtm 🍻

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@maurafortino maurafortino merged commit 1d20b6a into main Jun 14, 2023
@maurafortino maurafortino deleted the logger-basculehelper branch June 14, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants