Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cryptboot-grub-warning script #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ljfranklin
Copy link

  • Place this script at /usr/local/bin/grub-install to raise an error
    telling the user to run cryptboot update-grub instead
  • Little guard rail to prevent updating the bootloader and forgetting to
    sign the new binary
  • Use absolute path to call grub-install in cryptboot script

- Place this script at /usr/local/bin/grub-install to raise an error
  telling the user to run `cryptboot update-grub` instead
- Little guard rail to prevent updating the bootloader and forgetting to
  sign the new binary
- Use absolute path to call `grub-install` in `cryptboot` script
@jugalnet
Copy link

jugalnet commented Jan 18, 2019

I got locked out of my system because I forgot to run cryptboot update-grub after grub-install. This pull request addresses this exact issue well and imo should be merged in this branch.
Making this check a default would be a good idea in my opinion, adding the following to the PKGBUILD does the job.
mkdir -p "$pkgdir/usr/local/bin/"; ln -s "$pkgdir/etc/cryptboot-grub-warning" "$pkgdir/usr/local/bin/grub-install"

EDIT: Made a pull request with a few of my suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants