Support ES modules #148
Merged
Support ES modules #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matewilk
added a commit
to matewilk/use-debounce
that referenced
this pull request
Nov 23, 2022
matewilk
force-pushed
the
support-es-modules
branch
from
a463c1b to
1447144
Compare
matewilk
force-pushed
the
support-es-modules
branch
from
1447144 to
5a68494
Compare
|
Apologies for force pushes, didn't know how to properly link an issue with a PR. Now I know 😄 |
|
I'm seeing the build is failing, I think it might be due to the fact that the build uses node v12. I think the ES modules are supported from node v16. |
|
Resolved failures in #150 |
|
Thanks for the contribution @matewilk I'll cut a new release soon |
|
Github action report: https://github.com/xnimorz/use-debounce/actions/runs/3569486941/jobs/5999497098 |
|
Thank you @xnimorz, appreciate your library and prompt responses and actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for treating the
use-dabouncelibrary as a ES moduleAdds
type: "module"topackage.jsonfileChanges
jest.config.jsfile extension tojest.config.cjs- to opt out of ESM for this file