Implemented better indent control in TextRendererBase #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melodi17
commented
Dec 31, 2024
Melodi17
commented
- Added method for clearing all indents
- Added logic in PopIndent for when indents are below 1 (TODO mentioned implementing this)
…d case handling to PopIndent()
xoofx
reviewed
Jan 5, 2025
| @@ -174,10 +174,12 @@ public void PushIndent(string[] lineSpecific) | |||
|
|
|||
| public void PopIndent() | |||
| { | |||
| // TODO: Check | |||
| indents.RemoveAt(indents.Count - 1); | |||
| if (this.indents.Count > 0) | |||
There was a problem hiding this comment.
This is not better, because it hides the fact that there are more PopIndent than push, which is a bug, so this PR hides bugs. The TODO: Check was to say "provide a better error message" instead of failing with list removal.
There was a problem hiding this comment.
Ah, my bad sorry. I've added an exception to be thrown when it is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.