This repository has been archived by the owner on Jun 20, 2019. It is now read-only.
Add some basic TLS support via environment variable. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
xstevens
added a commit
that referenced
this pull request
Jan 26, 2016
Add some basic TLS support via environment variable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat of a work in progress, not working in my testing quite yet.
I'm not sure if Sarama's TLS configuration support lines up 100% with the official Kafka 0.9 implementation (IBM/sarama#581).
This code reads in some environment variables and configures either server-authenticated TLS (if you point
SSL_CA_BUNDLE_PATHat a PEM bundle of CA certs) or mutually-authenticated TLS with client certificates (if you also setSSL_CRT_PATHandSSL_KEY_PATHto PEM formatted client certificate and private key).cc @xstevens @tomwans